-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for concurrent Miri #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rustup changes LGTM. For the thread support it would be nice to have a way to show the stack for every thread and if a thread is blocking, what it is blocking on.
@oli-obk It seems that the Travis CI integration broke. |
works on master... cycling the PR |
This will need to change |
@vakaras rust-lang/miri#1284 got merged. Can you update this PR? |
Friendly ping @vakaras. |
Sorry, for taking so long to update this. I am a bit swamped with other things right now. |
I agree that this would be nice, but, unfortunately, this would be a more substantial change and right now I do not have enough time for that. |
that's totally fine in my book. We can add additional logic for showing the stack of other threads than the current one later. Let's just get the general logic working |
Opened #25 |
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
looks like everything there was resolved
Thanks so much for doing this and bearing with us through the changes! |
No problem and sorry that it took so long for me to come back to this. |
This PR includes two changes:
step
function to work with the updated interface of concurrent Miri.This PR depends on rust-lang/miri#1284