Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for concurrent Miri #23

Merged
merged 10 commits into from
Jul 21, 2020
Merged

Conversation

vakaras
Copy link
Contributor

@vakaras vakaras commented Mar 31, 2020

This PR includes two changes:

  1. Update Priroda to work with the newest version of Miri.
  2. Change the step function to work with the updated interface of concurrent Miri.

This PR depends on rust-lang/miri#1284

Copy link
Collaborator

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rustup changes LGTM. For the thread support it would be nice to have a way to show the stack for every thread and if a thread is blocking, what it is blocking on.

src/main.rs Outdated Show resolved Hide resolved
src/step.rs Outdated Show resolved Hide resolved
@bjorn3
Copy link
Collaborator

bjorn3 commented Apr 2, 2020

@oli-obk It seems that the Travis CI integration broke.

@oli-obk
Copy link
Owner

oli-obk commented Apr 2, 2020

works on master... cycling the PR

@oli-obk oli-obk closed this Apr 2, 2020
@oli-obk oli-obk reopened this Apr 2, 2020
@bjorn3
Copy link
Collaborator

bjorn3 commented Apr 2, 2020

This will need to change rust-toolchain once the rustc PR is merged.

@bjorn3
Copy link
Collaborator

bjorn3 commented May 11, 2020

@vakaras rust-lang/miri#1284 got merged. Can you update this PR?

@bjorn3
Copy link
Collaborator

bjorn3 commented Jul 14, 2020

Friendly ping @vakaras.

@vakaras
Copy link
Contributor Author

vakaras commented Jul 20, 2020

Sorry, for taking so long to update this. I am a bit swamped with other things right now.

@vakaras
Copy link
Contributor Author

vakaras commented Jul 20, 2020

The rustup changes LGTM. For the thread support it would be nice to have a way to show the stack for every thread and if a thread is blocking, what it is blocking on.

I agree that this would be nice, but, unfortunately, this would be a more substantial change and right now I do not have enough time for that.

@oli-obk
Copy link
Owner

oli-obk commented Jul 20, 2020

I agree that this would be nice, but, unfortunately, this would be a more substantial change and right now I do not have enough time for that.

that's totally fine in my book. We can add additional logic for showing the stack of other threads than the current one later. Let's just get the general logic working

bjorn3
bjorn3 previously requested changes Jul 20, 2020
src/step.rs Show resolved Hide resolved
src/step.rs Outdated Show resolved Hide resolved
src/step.rs Outdated Show resolved Hide resolved
@bjorn3
Copy link
Collaborator

bjorn3 commented Jul 20, 2020

I agree that this would be nice, but, unfortunately, this would be a more substantial change and right now I do not have enough time for that.

that's totally fine in my book. We can add additional logic for showing the stack of other threads than the current one later. Let's just get the general logic working

Opened #25

src/step.rs Outdated Show resolved Hide resolved
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
@oli-obk oli-obk dismissed bjorn3’s stale review July 21, 2020 10:05

looks like everything there was resolved

@oli-obk oli-obk merged commit 5245547 into oli-obk:master Jul 21, 2020
@oli-obk
Copy link
Owner

oli-obk commented Jul 21, 2020

Thanks so much for doing this and bearing with us through the changes!

@vakaras
Copy link
Contributor Author

vakaras commented Jul 21, 2020

No problem and sorry that it took so long for me to come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants