Update to latest rustc #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
requested changes
Feb 27, 2021
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 27, 2021
Add a getter for Frame.loc This is necessary for Priroda. For context see https://rust-lang.zulipchat.com/#narrow/stream/146212-t-compiler.2Fconst-eval/topic/Frame.3A.3Aloc.20no.20longer.20public/near/228070266 and oli-obk/priroda#27. cc `@DJMcNab` r? `@RalfJung`
Depends on a future nightly version 👻
bjorn3
reviewed
Feb 28, 2021
bjorn3
approved these changes
Feb 28, 2021
|
Hopefully a nightly has landed which this PR is compatible with 🎉 I'll check when I'm at a desktop computer. |
|
My PR missed the deadline for the latest nightly by one merge. |
|
It should work now - we've been bitten by |
|
Thanks for the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had a few complications so there are a handful of workarounds:
getmacro fromrocketwas panicking (at called unwrap onOption::Nonewith no further details)macros fixed this, so I did that and removed themFrame::locfield has been made private, although it looks like an accessor will be addedextern crate mirimeant to use the one which was inrustcSource, even though that is not correct.Whilst I'm here, I'm also going to handle the problems that we have from not following
rust_2018_idiomsThanks to @bjorn3 for answering my queries :)
This is a very cool project, and I hope it can become more useful. 'Perfect' debugging for rust programs is very compelling, with easy back in time debugging.