Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring API management #3

Open
olibos opened this issue Oct 19, 2022 · 3 comments
Open

Refactoring API management #3

olibos opened this issue Oct 19, 2022 · 3 comments

Comments

@olibos
Copy link
Owner

olibos commented Oct 19, 2022

Tasks:

  • Token should be stored and persisted for 30 minutes
  • Persist StationCodes, DeviceId/DeviceTypeId to avoid to request those everytime

Source: @fmarton #1 (comment)

@fmarton

This comment was marked as outdated.

@fmarton

This comment was marked as outdated.

@fmarton
Copy link

fmarton commented Oct 19, 2022

I hided my comments in this topic. I think the limits should be enough for operating this integration when no more api client.
I think token request in every 5 mins is more simplier than any other solution.
Static DevID, DevType shouldnot be complicated development (same than stationCode). A script may be enogh that get the right parameters. user can copy them into the configuration.yaml. Set this feature lower proirity.
Thank you
Ferenc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants