Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap osc-stuff in conditions #1

Open
othmar52 opened this issue Mar 28, 2014 · 2 comments
Open

wrap osc-stuff in conditions #1

othmar52 opened this issue Mar 28, 2014 · 2 comments
Labels

Comments

@othmar52
Copy link
Collaborator

i wondered if all osc-related code should be wrapped in

ifdef WITH_OSC

osc related code

endif

and enable osc with
./configure --enable-osc

probably then we have a better chance to get osc-functionality merged into xwax-core!?

i did the same thing with the tcp-hack http://pastebin.com/fwYFcZbK

@oligau
Copy link
Owner

oligau commented Mar 28, 2014

Yes. You're right. That's something I'll do soon.

On 28/03/14 05:59 AM, othmar52 wrote:

i wondered if all osc-related code should be wrapped in
#ifdef WITH_OSC
osc related code
#endif
and enable osc with
./configure --enable-osc

probably then we have a better chance to get osc-functionality merged
into xwax-core!?

i did the same thing with the tcp-hack http://pastebin.com/fwYFcZbK


Reply to this email directly or view it on GitHub
#1.

@othmar52
Copy link
Collaborator Author

i tried to create those conditions based on a diff between xwax-1.5-vanilla and this repo.
http://pastebin.com/Hy5xRjX4

unfortunately i did not have success. maybe you save some time when you use my tryout as a start. case not - no problem and just forget it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants