Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pbm screen sizes less hardcoded #424

Merged
merged 1 commit into from
Sep 4, 2016

Conversation

matthijskooijman
Copy link
Contributor

The .c files for the pbm bitmap-writing virtual devices contain
constants for the output width and height. Previously these constants
were used throughout the code, making it impossible to change the width
and height without changing these constants.

With this change, only the initialization uses the constants, but the
rest of the code reads back the width and height from the device
struct and uses those. This enables a user of these devices to change
the width and height to change the size of the output.

This was tested for all three of the pbm devices.

The .c files for the pbm bitmap-writing virtual devices contain
constants for the output width and height. Previously these constants
were used throughout the code, making it impossible to change the width
and height without changing these constants.

With this change, only the initialization uses the constants, but the
rest of the code reads back the width and height from the device
struct and uses those. This enables a user of these devices to change
the width and height to change the size of the output.

This was tested for all three of the pbm devices.
@olikraus olikraus merged commit 6ee45b8 into olikraus:master Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants