Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve symlinks before mounting system executable path to sandbox #206

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Virv12
Copy link
Member

@Virv12 Virv12 commented Dec 8, 2023

No description provided.

@Virv12 Virv12 force-pushed the sbin-symlink branch 3 times, most recently from 3ee7f58 to ca76ef1 Compare December 8, 2023 03:24
@Virv12 Virv12 marked this pull request as ready for review December 8, 2023 03:47
@Virv12 Virv12 marked this pull request as draft December 8, 2023 14:26
@Virv12 Virv12 marked this pull request as ready for review December 24, 2023 17:33
assert_eq!(config.executable, Path::new("/bin/sh"));
assert_eq!(
config.executable,
std::fs::canonicalize(Path::new("/bin/sh")).unwrap()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applications should note that the standard PATH to the shell cannot be assumed to be either /bin/sh or /usr/bin/sh, and should be determined by interrogation of the PATH returned by getconf PATH

https://pubs.opengroup.org/onlinepubs/009695399/utilities/sh.html

@dp1 dp1 merged commit 2f78121 into olimpiadi-informatica:master Jan 18, 2024
3 checks passed
@Virv12 Virv12 deleted the sbin-symlink branch January 18, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants