Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always return float for numeric values #5

Closed
olivergregorius opened this issue Jun 26, 2022 · 0 comments · Fixed by #6
Closed

Always return float for numeric values #5

olivergregorius opened this issue Jun 26, 2022 · 0 comments · Fixed by #6
Assignees
@olivergregorius
Labels
bug Something isn't working

Comments

@olivergregorius
Copy link
Owner

Contrary to registers.InverterEquipmentRegister.ActivePower which returns a float registers.MeterEquipmentRegister.ActivePowerreturns an int. Every numeric register value should be returned as a float value to avoid issues e.g. persisting these values as field "active_power" in an InfluxDB instance.
@olivergregorius olivergregorius added the bug Something isn't working label Jun 26, 2022
@olivergregorius olivergregorius self-assigned this Jun 26, 2022
olivergregorius added a commit that referenced this issue Jun 26, 2022
@olivergregorius
#5: Fixed numeric return value type to float
9743a0f
@olivergregorius olivergregorius mentioned this issue Jun 26, 2022
Merged
olivergregorius added a commit that referenced this issue Jun 26, 2022
@olivergregorius
#5: Fixed numeric return value type to float
fabd66a
olivergregorius added a commit that referenced this issue Jun 27, 2022
@olivergregorius
Fixed documentation for changes from #5, added requirement to use Pyt…
7bb3211 
…hon 3.10 or above
@olivergregorius olivergregorius mentioned this issue Jun 27, 2022
Merged
olivergregorius added a commit that referenced this issue Jun 27, 2022
@olivergregorius
Documentation fixes
ebd125d 
- Fixed documentation for changes from #5
- Added requirement to use Python 3.10 or above
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olivergregorius olivergregorius

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#5: Fixed numeric return value type to float olivergregorius/sun2000_modbus
1 participant
@olivergregorius