Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new register interface #17

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Add new register interface #17

merged 3 commits into from
Sep 27, 2022

Conversation

Kali-
Copy link
Contributor

@Kali- Kali- commented Sep 24, 2022

olivergregorius
olivergregorius requested changes Sep 24, 2022
View reviewed changes
Copy link
Owner

@olivergregorius olivergregorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution!
I just added some small renaming suggestions.

README.md Outdated Show resolved Hide resolved
sun2000_modbus/registers.py Outdated Show resolved Hide resolved
@olivergregorius olivergregorius self-assigned this Sep 24, 2022
@olivergregorius olivergregorius added the new feature New feature label Sep 24, 2022
@olivergregorius olivergregorius added this to the 1.3.0 milestone Sep 24, 2022
Giulio Cervera and others added 2 commits September 27, 2022 21:30
@olivergregorius
Update README.md
642e449 
Co-authored-by: Oliver Gregorius <98558972+olivergregorius@users.noreply.github.com>
@olivergregorius
Update sun2000_modbus/registers.py
25f7f15 
Co-authored-by: Oliver Gregorius <98558972+olivergregorius@users.noreply.github.com>
@olivergregorius olivergregorius merged commit d9578e1 into olivergregorius:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivergregorius olivergregorius olivergregorius approved these changes

Assignees

@olivergregorius olivergregorius

Labels
new feature New feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Kali- @olivergregorius