Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #417 #418

Merged
merged 3 commits into from
Oct 6, 2019
Merged

Fix #417 #418

merged 3 commits into from
Oct 6, 2019

Conversation

hoelzro
Copy link
Contributor

@hoelzro hoelzro commented Oct 5, 2019

This adds a test and a fix for #417

Copy link
Owner

@olivernn olivernn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this handle strings that have trailing white space?

I think the simplest approach is to just remove String#trim lib/tokenizer, both leading and trailing white space should be ignored by the check on line 46.

It'd be good to have a test for both the leading and trailing white space to verify we've covered both cases.

@olivernn
Copy link
Owner

olivernn commented Oct 5, 2019

Thanks for taking a look into this, I think the change required to fix this is even simpler though...

@hoelzro
Copy link
Contributor Author

hoelzro commented Oct 6, 2019

@olivernn Thanks for the feedback - I've just made the changes you requested and pushed them up to my fork!

@olivernn olivernn merged commit 15e24c4 into olivernn:master Oct 6, 2019
@olivernn olivernn mentioned this pull request Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants