Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add greedyCollapse option #193

Merged
merged 4 commits into from
Aug 7, 2021
Merged

Conversation

simonasdev
Copy link
Contributor

@simonasdev simonasdev commented Aug 3, 2021

Describe the change

Add an option to make deflating less greedy

Further comments

Some very long horizontal or vertical polygons get deflated too soon

@oliverroick
Copy link
Owner

Hi @simonasdev, thanks for the PR. This seems like a useful addition.

Before I can merge and cut a new release, would you be able to:

  • fix the lint issues,
  • add tests, and
  • add documentation?

I can help with those but I'm not sure when I'll get to it

@simonasdev
Copy link
Contributor Author

I've fixed lint issues and added documentation, but not yet sure how tests should be implemented. I guess I would need a fixture specific for this new option

@oliverroick
Copy link
Owner

Thanks for making these changes.

For testing, the best way to to this is to:

I can have a look at those over the weekend, if you need support

@oliverroick oliverroick merged commit aa6d46c into oliverroick:master Aug 7, 2021
@oliverroick
Copy link
Owner

I wasn't able to push the tests to your branch. I'm merging the PR and add the tests separately

@oliverroick oliverroick mentioned this pull request Aug 7, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants