Merge pull request #30 from oliviertassinari/improve-warnings

fix: improve the error message

docs/webpack/developmentConfig.js

@@ -20,6 +20,7 @@ export default {
     hot: true,
     historyApiFallback: true,
     port: PORT,
+    disableHostCheck: true, // For security checks, no need here.
 
     // webpack-dev-middleware options.
     stats: {

docs/yarn.lock

@@ -0,0 +1,4 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+

package.json

@@ -41,37 +41,37 @@
     "webpack": "1 || ^2 || ^2.2.0-rc"
   },
   "devDependencies": {
-    "autoprefixer": "^6.7.2",
+    "autoprefixer": "^7.1.1",
     "babel-cli": "^6.23.0",
     "babel-core": "^6.23.1",
     "babel-eslint": "^7.1.1",
-    "babel-loader": "^6.3.0",
+    "babel-loader": "^7.0.0",
     "babel-plugin-add-module-exports": "^0.2.1",
     "babel-preset-es2015": "^6.18.0",
     "babel-preset-react": "^6.23.0",
     "babel-preset-stage-1": "^6.16.0",
     "chai": "^3.5.0",
-    "css-loader": "^0.26.1",
+    "css-loader": "^0.28.2",
     "eslint": "^3.15.0",
-    "eslint-config-airbnb": "^14.1.0",
+    "eslint-config-airbnb": "^15.0.1",
     "eslint-plugin-babel": "^4.0.0",
     "eslint-plugin-flowtype": "^2.29.2",
     "eslint-plugin-import": "^2.2.0",
-    "eslint-plugin-jsx-a11y": "^3.0.0",
+    "eslint-plugin-jsx-a11y": "^5.0.3",
     "eslint-plugin-mocha": "^4.8.0",
-    "eslint-plugin-react": "^6.8.0",
+    "eslint-plugin-react": "^7.0.1",
     "extract-text-webpack-plugin": "^2.0.0-rc.3",
-    "flow-bin": "^0.39.0",
+    "flow-bin": "^0.46.0",
     "force-case-sensitivity-webpack-plugin": "^0.2.1",
     "html-webpack-plugin": "^2.28.0",
     "mocha": "^3.2.0",
     "node-sass": "^4.5.0",
-    "postcss-loader": "^1.3.0",
+    "postcss-loader": "^2.0.5",
     "react": "^15.4.1",
     "react-dom": "^15.4.1",
     "react-hot-loader": "^3.0.0-beta.6",
     "sass-loader": "^6.0.0",
-    "style-loader": "^0.13.1",
+    "style-loader": "^0.18.0",
     "webpack": "^2.2.1",
     "webpack-dev-server": "^2.3.0"
   }

src/index.js

@@ -127,10 +127,10 @@ export default class ServiceWorkerPlugin {
 
     if (!asset) {
       compilation.errors.push(
-        new Error('ServiceWorkerPlugin: ServiceWorker entry is not found in output assets'),
+        new Error('ServiceWorkerPlugin: the `entry` option is incorrect.'),
       );
-
-      return Promise.reject();
+      callback();
+      return;
     }
 
     const jsonStats = compilation.getStats().toJson({
@@ -180,7 +180,7 @@ export default class ServiceWorkerPlugin {
 
     const templatePromise = this.options.template(serviceWorkerOption);
 
-    return templatePromise.then((template) => {
+    templatePromise.then((template) => {
       const serviceWorkerOptionInline = JSON.stringify(serviceWorkerOption, null, minify ? 0 : 2);
 
       const source = `

src/index.spec.js

@@ -35,8 +35,7 @@ describe('ServiceWorkerPlugin', () => {
       return serviceWorkerPlugin
         .handleEmit(compilation, {
           options: {},
-        }, () => {})
-        .then(() => {
+        }, () => {
           assert.strictEqual(compilation.assets[filename].source(), trim(`
 var serviceWorkerOption = {
   "assets": [
@@ -74,8 +73,7 @@ var serviceWorkerOption = {
         return serviceWorkerPlugin
           .handleEmit(compilation, {
             options: {},
-          }, () => {})
-          .then(() => {
+          }, () => {
             assert.strictEqual(compilation.assets[filename].source(), trim(`
 var serviceWorkerOption = {
   "bar": "foo",