Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sas.upenn.edu to ignore list linkchecker #394

Merged
merged 18 commits into from
Nov 25, 2024
Merged

Conversation

pwalczysko
Copy link
Member

Copy link
Member

@melissalinkert melissalinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this open for a few days to fix the build is fine with me. The certificate only expired yesterday, so I would think there is a strong possibility it gets fixed upstream in that time.

If this is still a problem on Monday, though, I would propose to instead remove the link from src/main/resources/format-pages.txt, as ignoring the invalid certificate does not provide anything useful:

$ curl -k https://www.sas.upenn.edu/~heiney/html-physics/datasqueeze/
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Proxy Error</title>
</head><body>
<h1>Proxy Error</h1>
The proxy server could not handle the request <em><a href="/~heiney/html-physics/datasqueeze/">GET&nbsp;/~heiney/html-physics/datasqueeze/</a></em>.<p>
Reason: <strong>Error during SSL Handshake with remote server</strong></p><p />
</body></html>

sphinx/conf.py Outdated
@@ -389,5 +389,6 @@ def getValue(value):
r'https://trac.openmicroscopy.org*',
r'http://openslide.cs.cmu.edu*', # NameResolutionError
r'https://openslide.cs.cmu.edu*', # NameResolutionError
r'https://tronche.com/computer-graphics/*' # NameResolutionError
r'https://tronche.com/computer-graphics/*', # NameResolutionError
r'http://www.bio-rad.com/*' # 403 Client Error: Forbidden for url
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try to use https instead of excluding?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in a3ef84e

sphinx/conf.py Outdated Show resolved Hide resolved
@pwalczysko
Copy link
Member Author

pwalczysko commented Oct 11, 2024

This PR is not making it to the Jenkins build because of #395 (comment) - the RtD sphinx build is broken for all PRs in this repo

@pwalczysko
Copy link
Member Author

I think the sphinx build problem is python/cpython#104818 - we are using Sphinx v5.3.0 with Python 3.13 which does not work because Python 3.13 does not have the imghdr module.

They propose 2 ways of fixing as far as I understand:

  • Sphinx 6.2.0 or
  • Python 3.12 or lower

@sbesson
Copy link
Member

sbesson commented Oct 11, 2024

You're correct, the issue is that the versions of Python and Sphinx used in the current build are incompatible. Either we need a Python downgrade or a Sphinx upgrade.

Unfortunately, how the versions are ultimately specified and picked is fairly opaque and hidden between multiple layers (.readthedocs.yml -> mambaforge -> environment.yml). #396 is an initial attempt at making one of the two changes above but without success so far

@pwalczysko
Copy link
Member Author

rebased this on top of master to fix build as #396 is merged. Thank you @sbesson

@jburel jburel merged commit e2ec252 into ome:master Nov 25, 2024
1 check passed
@pwalczysko pwalczysko deleted the fix-link branch November 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants