Cap rich to version 10.x #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of rich includes breaking changes that affects ansible-lint. A new version of ansible-lint has just been released with support for rich 11 but our Ansible infrastructure is on Molecule 2 which caps ansible-lint to 4.x. Until we are ready to upgrade our infrastructure to Molecule 3, this should allow our Ansible CI to keep testing roles and playbooks
|
As a proof of concept https://github.com/sbesson/ansible-role-omero-prometheus-exporter/runs/4761840718?check_suite_focus=true is a build using 82dd2a4 via sbesson/action-ome-ansible-molecule@721581b which demonstrates the effect of this fix. It can be compared to the former build for the same role - https://github.com/ome/ansible-role-omero-prometheus-exporter/actions/runs/1674944111. I'll follow the discussion in ansible/ansible-lint#1795 to see if an |
joshmoore
approved these changes
Jan 11, 2022
|
Captured the Molecule 3 upgrade as ome/ansible-roles#137. In the interim, I'll make a patch release of ome-ansible-molecule so that we keep testing existing roles with Molecule 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of rich includes breaking changes that affects ansible-lint.
A new version of ansible-lint has just been released with support for rich 11 (see https://github.com/ansible-community/ansible-lint/releases/tag/v5.3.2) but our Ansible infrastructure is on Molecule 2 which caps ansible-lint to 4.x. Until we are ready to upgrade our infrastructure to Molecule 3, this should allow our Ansible CI to keep testing roles and playbooks