Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude some minio transitive dependencies. #40

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

mtbc
Copy link
Member

@mtbc mtbc commented Mar 14, 2019

Excludes some possibly troublesome transitive dependencies introduced by the S3 work.

  • commons-codec:commons-codec
  • commons-logging:commons-logging
  • com.google.code.findbugs:annotations

See https://trello.com/c/5l4Vrbcd/117-review-common-codecs-dependency and https://sourceforge.net/p/findbugs/bugs/1341/.

- commons-codec:commons-codec
- commons-logging:commons-logging
- com.google.code.findbugs:annotations
@sbesson
Copy link
Member

sbesson commented Mar 19, 2019

In addition to the card mentioned above, this PR helps resolving the dependency issues raised in https://forum.image.sc/t/duplicate-classes-stemming-from-io-minio-minio-artifact/23794.

Functionally, I could not see any regression apparent from this exclusions. Unit tests keep passing. At the Bio-Formats level, calling showinf against a TIFF file on public S3 location still works with the same limitations as in Bio-Formats 6.0.0.
The repository tests are still in flux due to ongoing work on HCS metadata so I would propose to wait until we have a final green build. The only addition might be to review this has no impact when coupling up to the OMERO.server components. Otherwise, this change should be suitable for an ome-common release (patch or minor?).

@sbesson sbesson merged commit de9cb6d into ome:master Apr 9, 2019
@mtbc mtbc deleted the minio-exclusions branch April 9, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants