strconv.Atoi used for converting string to integer #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this changes have any impact on existing setups ? |
thakurajayL
reviewed
Jun 2, 2022
simapp.go
Outdated
| @@ -726,7 +726,7 @@ func UpdateConfig(f string) error { | |||
| var msg configMessage | |||
| msg.msgPtr = reqMsgBody | |||
| msg.msgType = subscriber | |||
| msg.name = strconv.FormatUint(k, 10) | |||
| msg.name = strconv.FormatUint(uint64(k), 10) | |||
There was a problem hiding this comment.
will this not remove the 0's at the start of IMSI ? Can you check if message sent towards Webconsole has right URL. msg.name is used to " httpend = subscriberHttpend + msg.name"
There was a problem hiding this comment.
delete might not work.. let me check
There was a problem hiding this comment.
Thanks Ajay. Delete didn't work. Fixed it and pushed changes. Add /delete of subscribers worked with latest
vthiruveedula
force-pushed
the
dev-imsi-issue
branch
from
10bb2cd
to
f8e93c8
Compare
thakurajayL
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to integer value