Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMF crash fix & log cleanup #177

Merged
merged 8 commits into from
Jan 2, 2024
Merged

SMF crash fix & log cleanup #177

merged 8 commits into from
Jan 2, 2024

Conversation

thakurajayL
Copy link
Contributor

No description provided.

@dafATonf
Copy link

test this please

@gab-arrobo
Copy link
Contributor

@thakurajayL please rebase your PR

gab-arrobo
gab-arrobo requested changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. I added a few comments/edits

context/db.go Outdated Show resolved Hide resolved
context/db.go Outdated Show resolved Hide resolved
context/db.go Outdated Show resolved Hide resolved
context/db.go Outdated Show resolved Hide resolved
context/db.go Outdated Show resolved Hide resolved
context/db_uptunnel.go Outdated Show resolved Hide resolved
context/sm_context.go Outdated Show resolved Hide resolved
pfcp/adapter/adapter.go Outdated Show resolved Hide resolved
pfcp/adapter/adapter.go Show resolved Hide resolved
qos/qos_rule_test.go Outdated Show resolved Hide resolved
@thakurajayL
Copy link
Contributor Author

retest this please

gab-arrobo
gab-arrobo previously approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

context/sm_context.go Outdated Show resolved Hide resolved
gab-arrobo
gab-arrobo approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gab-arrobo gab-arrobo merged commit e71d05c into omec-project:master Jan 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gab-arrobo gab-arrobo gab-arrobo approved these changes

@badhrinathpa badhrinathpa Awaiting requested review from badhrinathpa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thakurajayL @dafATonf @gab-arrobo @badhrinathpa