Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps go version to 1.21 (latest stable) #179

Merged

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Oct 10, 2023

This project currently uses Go 1.16 which is end of life. This PR bumps the go version to 1.21 which is the latest stable release.

The update is accomplished by running following commands:

go mod edit -go=1.21
go mod tidy

Reference: https://tip.golang.org/doc/go1.21

@onf-bot
Copy link
Contributor

onf-bot commented Oct 10, 2023

Can one of the admins verify this patch?

1 similar comment
@onf-bot
Copy link
Contributor

onf-bot commented Oct 10, 2023

Can one of the admins verify this patch?

@gatici gatici force-pushed the TELCO-671-Update-smf-go-version branch 3 times, most recently from 8d6ba22 to 0bfbef1 Compare October 11, 2023 20:57
@onf-bot
Copy link
Contributor

onf-bot commented Oct 16, 2023

test this please

Signed-off-by: gatici <gulsum.atici@canonical.com>
@gatici gatici force-pushed the TELCO-671-Update-smf-go-version branch from 0bfbef1 to 6676957 Compare October 27, 2023 09:53
@gatici
Copy link
Contributor Author

gatici commented Oct 30, 2023

This PR is tested by building new image and deploying sdcore-bundle successfully.

@gatici
Copy link
Contributor Author

gatici commented Nov 9, 2023

Note: PR: #182 disables the golint checks temporarily to make the CI pass.

@dafATonf
Copy link

test this please

@gab-arrobo
Copy link
Contributor

test this please

Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (manually tested changes with AiaB)

@gab-arrobo gab-arrobo merged commit e30f231 into omec-project:master Nov 24, 2023
4 of 7 checks passed
@gab-arrobo
Copy link
Contributor

@gatici, would it be possible that you also bump up the go version for the upfadapter (it is a directory inside this repo that also has a go.mod file, https://github.com/omec-project/smf/blob/master/upfadapter/go.mod)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants