github action support #24
Conversation
.github/workflows/docker.yml
Outdated
| username: ${{ secrets.DOCKER_HUB_LOGIN }} | ||
| password: ${{ secrets.DOCKER_HUB_PASSWORD }} | ||
|
|
||
| - name: Build and push "master-latest" Docker images |
There was a problem hiding this comment.
Are we using this image anywhere ? Else just compiling should be good enough ?
There was a problem hiding this comment.
will comment out the docker push part. can enable later.
.github/workflows/docker.yml
Outdated
|
|
||
| - name: Build and push "master-latest" Docker images | ||
| env: | ||
| DOCKER_TAG: master-${{ env.GIT_SHA_SHORT } |
There was a problem hiding this comment.
Do we get branch tag in the GitHub action ? As such this is ok for now, but want to know if we can use destination branch
There was a problem hiding this comment.
Yes we can add branch name in tag :
- name: Build
run: docker build -t udm/tag-example:${GITHUB_REF##*/} .
Currently we are running for master only. so didnt add branch name.
.github/workflows/pull_request.yml
Outdated
| build: | ||
| env: | ||
| DOCKER_REGISTRY: "docker.io/" | ||
| DOCKER_REPOSITORY: "badhrinathpa/" |
There was a problem hiding this comment.
Open item to check with ONF infra team ? @amolonf would you be able to get this work with omec-project
| run: | | ||
| git --no-pager diff | ||
|
|
||
| # Build again and commit |
There was a problem hiding this comment.
I see only build and no commit... Did I miss anything ?
There was a problem hiding this comment.
good catch. will add the commit part.
Makefile
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Copyright 2019 free5GC.org | |||
There was a problem hiding this comment.
Keep... free5g copyright after SPDX header.
badhrinathpa
force-pushed
the
gitaction
branch
from
4477fab
to
e747355
Compare
badhrinathpa
force-pushed
the
gitaction
branch
from
e747355
to
be60da4
Compare
No description provided.