Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpine base image in Dockerfiles to v3.11 #1450

Merged
merged 13 commits into from
Apr 16, 2020
Merged

Update alpine base image in Dockerfiles to v3.11 #1450

merged 13 commits into from
Apr 16, 2020

Conversation

arthurk
Copy link
Contributor

@arthurk arthurk commented Apr 6, 2020

This PR updates the alpine docker base image to the latest version 3.11

The alpine release notes are available here https://wiki.alpinelinux.org/wiki/Alpine_Linux:Releases

Testing

Docker build the images. CI should show us if this is successful.

@coveralls
Copy link

coveralls commented Apr 7, 2020

Coverage Status

Coverage remained the same at 77.583% when pulling 298288f on bump-alpine into 0b81354 on master.

@InoMurko
Copy link
Contributor

InoMurko commented Apr 8, 2020

We could test this now I think if you resolve the merge conflicts!

@unnawut
Copy link
Contributor

unnawut commented Apr 10, 2020

@arthurk The error is a bit hidden behind "Start daemon services" step, probably because docker-compose logs returns a normal exit status. Something about missing OpenSSL so I think it's related to the alpine bump. Here's the relevant logs:

ERROR: for watcher  Container "7cae21c7e36b" is unhealthy.

ERROR: for watcher_info  Container "7cae21c7e36b" is unhealthy.
ERROR: Encountered errors while bringing up the project.
Makefile:12: recipe for target 'start_daemon_services' failed

...

childchain      | [load_failed,"Failed to load NIF library: 'Error loading shared library libcrypto.so.43: No such file or directory (needed by /app/lib/crypto-4.6.5/priv/lib/crypto.so)'","OpenSSL might not be installed on this system.\n"]
childchain      | "Unable to load crypto library. Failed with error:~n\"~p, ~s\"~n~s"
childchain      | {error_logger,error_msg}
childchain      | #{label=>{proc_lib,crash},report=>[[{initial_call,{supervisor,kernel,['Argument__1']}},{pid,<0.1349.0>},{registered_name,[]},{error_info,{exit,{on_load_function_failed,crypto},[{init,run_on_load_handlers,0,[]},{kernel,init,1,[{file,"kernel.erl"},{line,189}]},{supervisor,init,1,[{file,"supervisor.erl"},{line,295}]},{gen_server,init_it,2,[{file,"gen_server.erl"},{line,374}]},{gen_server,init_it,6,[{file,"gen_server.erl"},{line,342}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,249}]}]}},{ancestors,[kernel_sup,<0.1335.0>]},{message_queue_len,0},{messages,[]},{links,[<0.1337.0>]},{dictionary,[]},{trap_exit,true},{status,running},{heap_size,610},{stack_size,27},{reductions,265}],[]]}
childchain      | #{label=>{supervisor,start_error},report=>[{supervisor,{local,kernel_sup}},{errorContext,start_error},{reason,{on_load_function_failed,crypto}},{offender,[{pid,undefined},{id,kernel_safe_sup},{mfargs,{supervisor,start_link,[{local,kernel_safe_sup},kernel,safe]}},{restart_type,permanent},{shutdown,infinity},{child_type,supervisor}]}]}
childchain      | #{label=>{proc_lib,crash},report=>[[{initial_call,{application_master,init,['Argument__1','Argument__2','Argument__3','Argument__4']}},{pid,<0.1334.0>},{registered_name,[]},{error_info,{exit,{{shutdown,{failed_to_start_child,kernel_safe_sup,{on_load_function_failed,crypto}}},{kernel,start,[normal,[]]}},[{application_master,init,4,[{file,"application_master.erl"},{line,138}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,249}]}]}},{ancestors,[<0.1333.0>]},{message_queue_len,1},{messages,[{'EXIT',<0.1335.0>,normal}]},{links,[<0.1333.0>,<0.1332.0>]},{dictionary,[]},{trap_exit,true},{status,running},{heap_size,610},{stack_size,27},{reductions,193}],[]]}
childchain      | #{label=>{application_controller,exit},report=>[{application,kernel},{exited,{{shutdown,{failed_to_start_child,kernel_safe_sup,{on_load_function_failed,crypto}}},{kernel,start,[normal,[]]}}},{type,permanent}]}
childchain      | {"Kernel pid terminated",application_controller,"{application_start_failure,kernel,{{shutdown,{failed_to_start_child,kernel_safe_sup,{on_load_function_failed,crypto}}},{kernel,start,[normal,[]]}}}"}
childchain      |     args:     format:     label: 2020-04-10 04:55:13.081280 crash_report        2020-04-10 04:55:13.081327 supervisor_report   2020-04-10 04:55:14.083541 crash_report        2020-04-10 04:55:14.083735 std_info            Kernel pid terminated (application_controller) ({application_start_failure,kernel,{{shutdown,{failed_to_start_child,kernel_safe_sup,{on_load_function_failed,crypto}}},{kernel,start,[normal,[]]}}})
childchain      | 

I'll submit a separate PR to fix this silent failure.

@unnawut
Copy link
Contributor

unnawut commented Apr 10, 2020

LGTM now. Thank you! Let's merge omisego-images/docker-elixir-omg#40 and get the stable image tag onto this PR.

@unnawut
Copy link
Contributor

unnawut commented Apr 10, 2020

@arthurk
Copy link
Contributor Author

arthurk commented Apr 13, 2020

@unnawut it's using the new stable image now

Copy link
Contributor

@InoMurko InoMurko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls update snapshots.ev and circleci/config to use the same stable image?

SNAPSHOT_MIX_EXIT_PERIOD_SECONDS_240=https://storage.googleapis.com/circleci-docker-artifacts/data-elixir-omg-tester-plasma-deployer-stable-20200407-MIN_EXIT_PERIOD-240-PLASMA_CONTRACTS_SHA-a69c763f239b81c5eb46b0bbdef3459f764360dc.tar.gz

stable-20200407

@unnawut unnawut merged commit b22ea96 into master Apr 16, 2020
@unnawut unnawut deleted the bump-alpine branch April 16, 2020 09:58
@unnawut unnawut added the chore Technical work that does not affect service behaviour label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Technical work that does not affect service behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants