Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inomurko/macos nightly build fix #1464

Merged
merged 5 commits into from
Apr 13, 2020
Merged

Inomurko/macos nightly build fix #1464

merged 5 commits into from
Apr 13, 2020

Conversation

InoMurko
Copy link
Contributor

@InoMurko InoMurko commented Apr 10, 2020 •
edited
Loading

Overview

Nightly build for macos depends on wget - we can use curl which comes shipped with every OS.

Changes

  • remove wget where necessary

Testing

@coveralls
Copy link

coveralls commented Apr 10, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 77.341% when pulling ad74b84 on inomurko/macos_nightly_build_fix into e188f0e on master.

@InoMurko InoMurko merged commit 283005e into master Apr 13, 2020
@InoMurko InoMurko deleted the inomurko/macos_nightly_build_fix branch April 13, 2020 21:19
@unnawut unnawut added the chore Technical work that does not affect service behaviour label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achiurizo achiurizo achiurizo approved these changes

@unnawut unnawut unnawut approved these changes

@jarindr jarindr Awaiting requested review from jarindr

@kevsul kevsul Awaiting requested review from kevsul

Assignees
No one assigned
Labels
chore Technical work that does not affect service behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@InoMurko @coveralls @achiurizo @unnawut