Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installation instructions #1465

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Update installation instructions #1465

merged 2 commits into from
Apr 10, 2020

Conversation

pnowosie
Copy link
Contributor

📋 Add associated issues, tickets, docs URL here.

Overview

I've recently run setup on clean Ubuntu machine just to find our instruction are broken.

unnawut
unnawut approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@unnawut unnawut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️❤️❤️

InoMurko
InoMurko suggested changes Apr 10, 2020
View reviewed changes
docs/install.md Outdated Show resolved Hide resolved
@pnowosie
fix: apply Ino's suggestion
befb528 
Co-Authored-By: Ino Murko <ino.murko@outlook.com>
@pnowosie pnowosie requested a review from InoMurko April 10, 2020 11:10
pgebal
pgebal suggested changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@pgebal pgebal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update bin/setup to install geth 1.9.12

@InoMurko
Copy link
Contributor

Please update bin/setup to install geth 1.9.12

I think it does already:

install_linux_geth(){
  echo "Installing Geth 1.9.12"
  mkdir gethDownload \
  && wget -qO- "https://gethstore.blob.core.windows.net/builds/geth-linux-amd64-1.9.12-b6f1c8dc.tar.gz" | tar xvz -C gethDownload --strip-components 1 \
  && cd gethDownload \
  && mkdir -p /usr/local/bin \
  && sudo mv geth /usr/local/bin/ \
  && cd .. \
  && rm -r gethDownload
}

@pgebal
Copy link
Contributor

pgebal commented Apr 10, 2020

Please update bin/setup to install geth 1.9.12

I think it does already:

install_linux_geth(){
  echo "Installing Geth 1.9.12"
  mkdir gethDownload \
  && wget -qO- "https://gethstore.blob.core.windows.net/builds/geth-linux-amd64-1.9.12-b6f1c8dc.tar.gz" | tar xvz -C gethDownload --strip-components 1 \
  && cd gethDownload \
  && mkdir -p /usr/local/bin \
  && sudo mv geth /usr/local/bin/ \
  && cd .. \
  && rm -r gethDownload
}

True, I have not pulled recent master.

@coveralls
Copy link

coveralls commented Apr 10, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 77.371% when pulling befb528 on papa/improve-ubuntu-setup into e1f8acf on master.

@pnowosie
Copy link
Contributor Author

Please update bin/setup to install geth 1.9.12

I think you did it recently

@pnowosie pnowosie merged commit 91cb67f into master Apr 10, 2020
@pnowosie pnowosie deleted the papa/improve-ubuntu-setup branch April 10, 2020 12:21
@unnawut unnawut added the documentation Changes to user manual and API documentations label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgebal pgebal pgebal approved these changes

@InoMurko InoMurko InoMurko approved these changes

@unnawut unnawut unnawut approved these changes

@boolafish boolafish Awaiting requested review from boolafish

Assignees
No one assigned
Labels
documentation Changes to user manual and API documentations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pnowosie @InoMurko @pgebal @coveralls @unnawut