Break down incoming events to publish separately #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnawut
reviewed
Apr 17, 2020
apps/omg_child_chain/lib/omg_child_chain/datadog_event/contract_event_consumer.ex
Show resolved
Hide resolved
| topic_name = self() |> :erlang.pid_to_list() |> to_string() | ||
| sig = "#{topic_name}(bytes32)" | ||
| data = [%{event_signature: sig}, %{event_signature: sig}] | ||
| {:root_chain, topic_name} |> OMG.Bus.Event.new(:data, data) |> OMG.Bus.direct_local_broadcast() | ||
|
|
||
| assert_receive {:event, _, _} | ||
| Enum.each(data, fn _ -> | ||
| assert_receive {:event, _, _} |
There was a problem hiding this comment.
Now that it expect 2 events, should we check that they're indeed the two events, and not one event reported twice?
There was a problem hiding this comment.
Absolutely, i'm taking the message into equation then
unnawut
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Partly #1426
Overview
This enables to break down and send separate events to Datadog, when events consumed from Ethereum event listeners come in bulk
Changes
OMG.Watcher.DatadogEvent.ContractEventConsumerand the Childchain sibling to iterate and send received events individuallyTesting