Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move db storage out of docker containers #1473

Merged
merged 3 commits into from
Apr 17, 2020

Conversation

kevsul
Copy link
Contributor

@kevsul kevsul commented Apr 17, 2020

Overview

Previously when running docker-compose, the rocksdb data dir was stored inside the childchain, watcher and watcher_info docker containers, which meant that they were lost every time the container was restarted, so the services were out of sync with local geth, which meant that any time you had to start a new chain and redeploy the contracts again on every restart.

Moving the rocksdb data dir out of the container makes it persistent, so that the services can be restarted and they will pick up where they left off.

Changes

  • In docker-compose.yaml, mount /data as a volume and use it as the rocksdb data dir for childchain, watcher and watcher_info. Same pattern as the geth container.

@kevsul kevsul requested review from InoMurko and unnawut and removed request for InoMurko April 17, 2020 10:34
@unnawut
Copy link
Contributor

unnawut commented Apr 17, 2020

Could you also update Makefile's docker-nuke?

- docker-compose down --remove-orphans
+ docker-compose down --remove-orphans --volumes

So the volume doesn't hang around when geth snapshot is wiped.

@coveralls
Copy link

coveralls commented Apr 17, 2020

Coverage Status

Coverage remained the same at 77.581% when pulling b127860 on kevin/move_rocksdb_out_of_docker_containers into 4389bce on master.

@kevsul kevsul merged commit 00cf991 into master Apr 17, 2020
@kevsul kevsul deleted the kevin/move_rocksdb_out_of_docker_containers branch April 17, 2020 15:31
@unnawut unnawut added the chore Technical work that does not affect service behaviour label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Technical work that does not affect service behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants