refactor: add prerequisites for makefile targets involving docker-compose #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgebal
force-pushed
the
pgebal/fix_dependency_on_local_child_chain_env_in_makefile
branch
from
371d701
to
6b4cfa2
Compare
pgebal
force-pushed
the
pgebal/fix_dependency_on_local_child_chain_env_in_makefile
branch
from
6b4cfa2
to
487ac43
Compare
InoMurko
reviewed
Apr 17, 2020
pgebal
force-pushed
the
pgebal/fix_dependency_on_local_child_chain_env_in_makefile
branch
from
487ac43
to
6d764e5
Compare
InoMurko
approved these changes
Apr 17, 2020
kevsul
approved these changes
Apr 20, 2020
pgebal
deleted the
pgebal/fix_dependency_on_local_child_chain_env_in_makefile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1272
It does not solve the issue in general. It solves it only for
makecommands involvingdocker-composewith default docker-compose file.