[2] Add root chain transaction hash to InvalidExit and UnchallengedExit events

apps/omg_watcher/lib/omg_watcher/exit_processor/exit_info.ex

@@ -48,7 +48,7 @@ defmodule OMG.Watcher.ExitProcessor.ExitInfo do
           # this means the exit has been first seen active. If false, it won't be considered harmful
           is_active: boolean(),
           eth_height: pos_integer(),
-          root_chain_txhash: Crypto.hash_t()
+          root_chain_txhash: Crypto.hash_t() | nil
         }
 
   @spec new(map(), map()) :: t()
@@ -125,7 +125,8 @@ defmodule OMG.Watcher.ExitProcessor.ExitInfo do
       exiting_txbytes: exit_info.exiting_txbytes,
       is_active: exit_info.is_active,
       eth_height: exit_info.eth_height,
-      root_chain_txhash: exit_info.root_chain_txhash
+      # defaults value to nil if non-existent in the DB.
+      root_chain_txhash: Map.get(exit_info, :root_chain_txhash, nil)
     }
 
     {Utxo.Position.from_db_key(db_utxo_pos), struct!(__MODULE__, value)}

apps/omg_watcher/test/omg_watcher/exit_processor/core_test.exs

@@ -38,6 +38,35 @@ defmodule OMG.Watcher.ExitProcessor.CoreTest do
   @utxo_pos2 Utxo.position(@late_blknum - 1_000, 0, 1)
 
   describe "generic sanity checks" do
+    test "can initialise with standard exits that do not have recently introduced keys" do
+      recent_keys = [:root_chain_txhash]
+      utxo_position = {0, 0, 0}
+
+      exit_info = %{
+        amount: 1,
+        currency: random_bytes(20),
+        eth_height: 1,
+        exit_id: 1,
+        exiting_txbytes: random_bytes(32),
+        is_active: false,
+        owner: random_bytes(20)
+      }
+
+      {:ok, %{exits: exits}} =
+        Core.init(
+          [
+            {utxo_position, exit_info}
+          ],
+          [],
+          []
+        )
+
+      Enum.each(recent_keys, fn recent_key ->
+        value = Map.get(exits, recent_key)
+        assert value == nil
+      end)
+    end
+
     test "can start new standard exits one by one or batched", %{processor_empty: empty, alice: alice, bob: bob} do
       standard_exit_tx1 = TestHelper.create_recovered([{1, 0, 0, alice}], @eth, [{alice, 10}])
       standard_exit_tx2 = TestHelper.create_recovered([{1, 0, 0, alice}], @eth, [{bob, 10}, {bob, 10}])