who monitors the monitor #1488
Merged
who monitors the monitor #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2020 12:23
InoMurko
commented
Apr 24, 2020
| @@ -186,7 +186,7 @@ jobs: | |||
| _counter=$(mix credo --only Credo.Check.Readability.SinglePipe | grep -c "Use a function call when a pipeline is only one function long") | |||
| echo "Current Credo.Check.Readability.SinglePipe occurrences:" | |||
| echo $_counter | |||
| if [ $_counter -gt 367 ]; then | |||
| if [ $_counter -gt 359 ]; then | |||
pgebal
approved these changes
Apr 24, 2020
|
This means that after this PR we would see the listener crashes in the logs? |
|
No. This changes nothing. Coordinator does not monitor listeners at all. I can’t find any code that would invoke monitoring. |
Aha ok got it! |
unnawut
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to receive exit signals from processes you need to monitor them. I don't see any code implying that RootChainCoordinator monitors Ethereum Event Listeners and these two chunks of code would ever get called. So I'm removing them.