test: watcher's /status.get cabbage test #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achiurizo
approved these changes
May 13, 2020
Comment on lines
+33
to
+76
| defthen ~r/^Operator can read byzantine_events$/, %{}, state do | ||
| assert is_list(state.service_response["data"]["byzantine_events"]) | ||
| {:ok, state} | ||
| end | ||
|
|
||
| defthen ~r/^Operator can read eth_syncing$/, %{}, state do | ||
| assert is_boolean(state.service_response["data"]["eth_syncing"]) | ||
| {:ok, state} | ||
| end | ||
|
|
||
| defthen ~r/^Operator can read in_flight_exits$/, %{}, state do | ||
| assert is_list(state.service_response["data"]["in_flight_exits"]) | ||
| {:ok, state} | ||
| end | ||
|
|
||
| defthen ~r/^Operator can read last_mined_child_block_number$/, %{}, state do | ||
| assert is_integer(state.service_response["data"]["last_mined_child_block_number"]) | ||
| {:ok, state} | ||
| end | ||
|
|
||
| defthen ~r/^Operator can read last_mined_child_block_timestamp$/, %{}, state do | ||
| assert is_integer(state.service_response["data"]["last_mined_child_block_timestamp"]) | ||
| {:ok, state} | ||
| end | ||
|
|
||
| defthen ~r/^Operator can read last_seen_eth_block_number$/, %{}, state do | ||
| assert is_integer(state.service_response["data"]["last_seen_eth_block_number"]) | ||
| {:ok, state} | ||
| end | ||
|
|
||
| defthen ~r/^Operator can read last_seen_eth_block_timestamp$/, %{}, state do | ||
| assert is_integer(state.service_response["data"]["last_seen_eth_block_timestamp"]) | ||
| {:ok, state} | ||
| end | ||
|
|
||
| defthen ~r/^Operator can read last_validated_child_block_number$/, %{}, state do | ||
| assert is_integer(state.service_response["data"]["last_validated_child_block_number"]) | ||
| {:ok, state} | ||
| end | ||
|
|
||
| defthen ~r/^Operator can read last_validated_child_block_timestamp$/, %{}, state do | ||
| assert is_integer(state.service_response["data"]["last_validated_child_block_timestamp"]) | ||
| {:ok, state} | ||
| end |
There was a problem hiding this comment.
feels like we could probably DRY this up a bit.
There was a problem hiding this comment.
Hmm do you have an example? These are specific to this test file so I didn't DRY them up so to keep them straight forward
There was a problem hiding this comment.
When I see the word DRY in elixir-omg repo being brought up I get triggered. :))))
InoMurko
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Script kiddie trying to move the simplest integration test (/status.get) into cabbage.
Changes
OMG.Watcher.Integration.StatusTestWatcherStatuscabbage testTesting