Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add Ink's log_encoding_error config #1512

Merged
merged 4 commits into from
May 15, 2020
Merged

fix: add Ink's log_encoding_error config #1512

merged 4 commits into from
May 15, 2020

Conversation

unnawut
Copy link
Contributor

@unnawut unnawut commented May 14, 2020

Closes #1511

Overview

Fix Ink's KeyError from missing a config value.

Will submit a PR to Ink to fix this permanently but this should keep us going.

Changes

  • Add :log_encoding_error config

Testing

N/A

@unnawut unnawut self-assigned this May 14, 2020
@coveralls
Copy link

coveralls commented May 14, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 78.167% when pulling 8b1dcd0 on unnawut/1511-ink into ff4977f on master.

@unnawut
Copy link
Contributor Author

unnawut commented May 14, 2020

Permanent fix in ivx/ink#59

@unnawut unnawut requested a review from T-Dnzt as a code owner May 15, 2020 08:15
@unnawut unnawut merged commit e8d486d into master May 15, 2020
@unnawut unnawut deleted the unnawut/1511-ink branch May 15, 2020 09:14
@unnawut unnawut added the bug Something isn't working label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achiurizo achiurizo achiurizo approved these changes

@InoMurko InoMurko InoMurko approved these changes

@mederic-p mederic-p mederic-p approved these changes

@T-Dnzt T-Dnzt Awaiting requested review from T-Dnzt

Assignees

@unnawut unnawut

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError: key :log_encoding_error not found
5 participants
@unnawut @coveralls @achiurizo @InoMurko @mederic-p