-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: consistent log message for new events #1534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, for a future PR, might be worth while to centralize our logging messages in some module?
True, the module name is easily helpful to be a json log attribute instead |
Coming back reading again, this looks like a silly PR. The original issue is the unparsed |
Overview
This fixes and makes consistent the event logging e.g.
by converting all into the last format with the full module name
Changes
Testing
Check the logs. Some monitors will ignore some alarms so the log should appear within a few minutes after boot.