Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Transaction filter by end_datetime #1595

Merged
merged 48 commits into from
Jun 24, 2020
Merged

Add Transaction filter by end_datetime #1595

merged 48 commits into from
Jun 24, 2020

Conversation

jarindr
Copy link
Contributor

@jarindr jarindr commented Jun 19, 2020

Adding filter for finance report on all transaction endpoint on watcher info

Overview

Add Transaction filter by end_datetime

Changes

Describe your changes and implementation choices. More details make PRs easier to review.

  • Add Transaction filter by end_datetime
  • Add test

Testing

mix test

Copy link
Contributor

@boolafish boolafish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test is missing?

@unnawut unnawut marked this pull request as draft June 22, 2020 04:22
@jarindr jarindr marked this pull request as ready for review June 22, 2020 12:29
priv/cabbage/apps/itest/lib/client.ex Outdated Show resolved Hide resolved
priv/cabbage/apps/itest/lib/client.ex Outdated Show resolved Hide resolved
@jarindr
Copy link
Contributor Author

jarindr commented Jun 23, 2020

unit test is missing?

added

@jarindr jarindr merged commit 273b9d8 into master Jun 24, 2020
@jarindr jarindr deleted the transaction-end-date branch June 24, 2020 06:56
boolafish added a commit that referenced this pull request Jun 25, 2020
* feat: sync v1.0.1 changes back to master (#1599)

* Inomurko/reorg block getter (#1554)

* dont store blockgetter events

* dont fetch blockgetter events through aggregator

* get_block_submitted_events

* get_block_submitted_events

* return tuple

* the right contract encoding

* unused api function

* prevent race condition for status cache (#1558)

* prevent race condition for status cache

* Changelog for v1.0.0 (#1556)

* restart strategy (#1565)

* restart strategy

* restart strategy

* restart strategy

* Update changelog for v1.0.0

* global block get interval (#1576)

* Update changelog for v1.0.0

* feat: increase ExitProcessor timeouts (#1592)

* increase timeouts

* docs: changelog

Co-authored-by: Unnawut Leepaisalsuwanna <unnawut@omisego.co>

* chore: update watcher docker-compose to v1.0.1

* docs: small non-content fix to changelog

Co-authored-by: Ino Murko <ino.murko@outlook.com>
Co-authored-by: Thibault <thibault@omisego.co>

* Add block processing queue to watcher info (#1560)

* [WIP] initial queuing work

* refactor: queue processing

* catch db timeouts

* update existing tests

* add tests

* continue with tests

* finish tests

* Fix integration test

* refactor

* refactor

* refactor tests

* remove retry_count

* remove on exist genserver shutdown

* add telemetry queue length event

* sobelow skip BinToTerm

* remove pending block status

* naming

* fix tests

* fix tests

* rename config

* remove unused alias

* fix PR minor comments

* missing file

* Add Transaction filter by end_datetime (#1595)

* add new query

* add if case

* format

* refactor

* add test

* fix feature spec

* use address

* fix assert

* fix test

* dummy assert

* add get single tx

* add wait tx

* working waiter pooler

* add wait helper cabbage test

* test end_datetime querty

* add swagger generator spec

* use second

* fix allow constraints

* update constraints validator

* fix test

* fix test

* edit name

* add empty line'

* more fixes

* fix warning

* refactor use the elixir way

* improve test

* fix test and typo

* use cheap fn

* sort

* use any

* use any boolean return

* use Enum.all

* final credo

* format

* use default params

* update constaints test for end_datetime

* mix format

* @default_paging constant

* fix test end_datetime

* fix test and rename feature file'

* mix format

* Revert "explain analyze updates (#1569)" (#1601)

This reverts commit 3431f26.
This commit is intended to be only deployed to develop env, thus a short life commit.
Reverting this in preparation of release.

* release artifacts (#1597)

* release artifacts

Co-authored-by: Unnawut Leepaisalsuwanna <921194+unnawut@users.noreply.github.com>
Co-authored-by: Ino Murko <ino.murko@outlook.com>
Co-authored-by: Thibault <thibault@omisego.co>
Co-authored-by: Mederic <32560642+mederic-p@users.noreply.github.com>
Co-authored-by: Jarindr Thitadilaka <jarindr23@gmail.com>
boolafish added a commit that referenced this pull request Jul 7, 2020
* chore: merge master back to v1.0.2 (#1606)

* feat: sync v1.0.1 changes back to master (#1599)

* Inomurko/reorg block getter (#1554)

* dont store blockgetter events

* dont fetch blockgetter events through aggregator

* get_block_submitted_events

* get_block_submitted_events

* return tuple

* the right contract encoding

* unused api function

* prevent race condition for status cache (#1558)

* prevent race condition for status cache

* Changelog for v1.0.0 (#1556)

* restart strategy (#1565)

* restart strategy

* restart strategy

* restart strategy

* Update changelog for v1.0.0

* global block get interval (#1576)

* Update changelog for v1.0.0

* feat: increase ExitProcessor timeouts (#1592)

* increase timeouts

* docs: changelog

Co-authored-by: Unnawut Leepaisalsuwanna <unnawut@omisego.co>

* chore: update watcher docker-compose to v1.0.1

* docs: small non-content fix to changelog

Co-authored-by: Ino Murko <ino.murko@outlook.com>
Co-authored-by: Thibault <thibault@omisego.co>

* Add block processing queue to watcher info (#1560)

* [WIP] initial queuing work

* refactor: queue processing

* catch db timeouts

* update existing tests

* add tests

* continue with tests

* finish tests

* Fix integration test

* refactor

* refactor

* refactor tests

* remove retry_count

* remove on exist genserver shutdown

* add telemetry queue length event

* sobelow skip BinToTerm

* remove pending block status

* naming

* fix tests

* fix tests

* rename config

* remove unused alias

* fix PR minor comments

* missing file

* Add Transaction filter by end_datetime (#1595)

* add new query

* add if case

* format

* refactor

* add test

* fix feature spec

* use address

* fix assert

* fix test

* dummy assert

* add get single tx

* add wait tx

* working waiter pooler

* add wait helper cabbage test

* test end_datetime querty

* add swagger generator spec

* use second

* fix allow constraints

* update constraints validator

* fix test

* fix test

* edit name

* add empty line'

* more fixes

* fix warning

* refactor use the elixir way

* improve test

* fix test and typo

* use cheap fn

* sort

* use any

* use any boolean return

* use Enum.all

* final credo

* format

* use default params

* update constaints test for end_datetime

* mix format

* @default_paging constant

* fix test end_datetime

* fix test and rename feature file'

* mix format

* Revert "explain analyze updates (#1569)" (#1601)

This reverts commit 3431f26.
This commit is intended to be only deployed to develop env, thus a short life commit.
Reverting this in preparation of release.

* release artifacts (#1597)

* release artifacts

Co-authored-by: Unnawut Leepaisalsuwanna <921194+unnawut@users.noreply.github.com>
Co-authored-by: Ino Murko <ino.murko@outlook.com>
Co-authored-by: Thibault <thibault@omisego.co>
Co-authored-by: Mederic <32560642+mederic-p@users.noreply.github.com>
Co-authored-by: Jarindr Thitadilaka <jarindr23@gmail.com>

* docs: v1.0.2 change logs (#1611)

* chore: bump version in VERSION file (#1613)

Co-authored-by: Unnawut Leepaisalsuwanna <921194+unnawut@users.noreply.github.com>
Co-authored-by: Ino Murko <ino.murko@outlook.com>
Co-authored-by: Thibault <thibault@omisego.co>
Co-authored-by: Mederic <32560642+mederic-p@users.noreply.github.com>
Co-authored-by: Jarindr Thitadilaka <jarindr23@gmail.com>
@unnawut unnawut added api API-level issues enhancement New feature or request labels Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API-level issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants