Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request body swagger #1609

Merged
merged 3 commits into from
Jul 7, 2020
Merged

Update request body swagger #1609

merged 3 commits into from
Jul 7, 2020

Conversation

jarindr
Copy link
Contributor

@jarindr jarindr commented Jun 25, 2020

Overview

In order to keep the Swagger specs up to date with ou API, we need to update the parameters for the transaction.all endpoint. The new param is end_datetime which can be used to pull transactions between specific timeframe.

@jarindr jarindr mentioned this pull request Jun 25, 2020
@unnawut
Copy link
Contributor

unnawut commented Jun 25, 2020

Can you try compile the specs? i.e. https://github.com/omgnetwork/elixir-omg/blob/master/apps/omg_watcher_rpc/priv/swagger/swagger.md

Otherwise it's a source file not picked up by all the toolings

@jarindr jarindr requested a review from unnawut July 7, 2020 06:13
@jarindr
Copy link
Contributor Author

jarindr commented Jul 7, 2020

Can you try compile the specs? i.e. https://github.com/omgnetwork/elixir-omg/blob/master/apps/omg_watcher_rpc/priv/swagger/swagger.md

Otherwise it's a source file not picked up by all the toolings

recompiled

@T-Dnzt T-Dnzt changed the title update request body swagger Update request body swagger Jul 7, 2020
@jarindr jarindr merged commit 32f22b7 into master Jul 7, 2020
@jarindr jarindr deleted the fix-swagger-request_bodies branch July 7, 2020 08:14
@unnawut unnawut added the documentation Changes to user manual and API documentations label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes to user manual and API documentations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants