Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pin elixir and erlang versions for asdf #1648

Merged
merged 2 commits into from
Jul 17, 2020
Merged

feat: pin elixir and erlang versions for asdf #1648

merged 2 commits into from
Jul 17, 2020

Conversation

unnawut
Copy link
Contributor

@unnawut unnawut commented Jul 16, 2020

Closes #1647

Overview

Pin elixir and erlang versions through .tool-versions file instead of in CI config, so we also enforce the same versions to local environments and installation docs too.

Changes

  • Add asdf's .tool-versions and pin the versions to the ones currently used by the CI
  • Remove the elixir/erlang version specs from CI config so a basic asdf install refers to .tool-versions

Testing

CI should pass, meaning that it's able to install from .tool-versions correctly and build/test are successful with this approach

@unnawut unnawut self-assigned this Jul 16, 2020
@unnawut unnawut requested a review from boolafish July 16, 2020 05:01
@pnowosie pnowosie self-requested a review July 17, 2020 10:44
pnowosie
pnowosie approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please 👍

@unnawut
Copy link
Contributor Author

unnawut commented Jul 17, 2020

Thanks everyone!

@unnawut unnawut merged commit 3fae490 into master Jul 17, 2020
@unnawut unnawut deleted the unnawut/asdf branch July 17, 2020 11:05
@unnawut unnawut added the chore Technical work that does not affect service behaviour label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnowosie pnowosie pnowosie approved these changes

@InoMurko InoMurko InoMurko approved these changes

@T-Dnzt T-Dnzt T-Dnzt approved these changes

@boolafish boolafish boolafish approved these changes

@kalouo kalouo kalouo approved these changes

@mederic-p mederic-p Awaiting requested review from mederic-p

Assignees

@unnawut unnawut

Labels
chore Technical work that does not affect service behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin elixir and erlang versions for asdf
6 participants
@unnawut @pnowosie @InoMurko @T-Dnzt @boolafish @kalouo