fix: unexpected http method

[ripzery]

Closes #1646

Overview

Adds one more clause to MethodParamsFilter to capture other HTTP methods.

Changes

• Adds def call(conn, _), do: conn to OMG.WatcherRPC.Web.Plugs.MethodParamFilter
• Adds def call(conn, _), do: conn to OMG.ChildChainRPC.Web.Plugs.MethodParamFilter

Testing

Runs unit tests or curl as follows:

Watcher

curl -X PUT http://localhost:7434/status.get -H "Content-Length: 0" | jq .

# PUT should not be allowed
{
  "data": {
    "code": "operation:not_found",
    "description": "Operation cannot be found. Check request URL.",
    "object": "error"
  },
  "service_name": "watcher",
  "success": false,
  "version": "1.0.3+e48599b"
}

curl -X POST http://localhost:7434/status.get -H "Content-Length: 0" | jq .

# POST should work as normal
{
  "data": {
    "byzantine_events": [],
    "contract_addr": {
      "erc20_vault": "0x135505d9f4ea773dd977de3b2b108f2dae67b63a",
      "eth_vault": "0x4e3aeff70f022a6d4cc5947423887e7152826cf7",
      "payment_exit_game": "0x89afce326e7da55647d22e24336c6a2816c99f6b",
      "plasma_framework": "0xc673e4ffcb8464faff908a6804fe0e635af0ea2f"
    },
    "eth_syncing": false,
    "in_flight_exits": [],
    "last_mined_child_block_number": 1000,
    "last_mined_child_block_timestamp": 1595075721,
    "last_seen_eth_block_number": 12365,
    "last_seen_eth_block_timestamp": 1595225750,
    "last_validated_child_block_number": 0,
    "last_validated_child_block_timestamp": 0,
    "services_synced_heights": [
      {
        "height": 672,
        "service": "block_getter"
      },
      {
        "height": 12346,
        "service": "challenges_responds_processor"
      },
      {
        "height": 12346,
        "service": "competitor_processor"
      },
      {
        "height": 12348,
        "service": "depositor"
      },
      {
        "height": 12346,
        "service": "exit_challenger"
      },
      {
        "height": 672,
        "service": "exit_finalizer"
      },
      {
        "height": 12346,
        "service": "exit_processor"
      },
      {
        "height": 672,
        "service": "ife_exit_finalizer"
      },
      {
        "height": 12346,
        "service": "in_flight_exit_processor"
      },
      {
        "height": 12346,
        "service": "piggyback_challenges_processor"
      },
      {
        "height": 12346,
        "service": "piggyback_processor"
      },
      {
        "height": 12364,
        "service": "root_chain_height"
      }
    ]
  },
  "service_name": "watcher",
  "success": true,
  "version": "1.0.3+e48599b"
}

Childchain

curl -X PUT http://localhost:9656/alarm.get -H "Content-Length: 0" | jq .

# PUT should not be allowed

{
  "data": {
    "code": "operation:not_found",
    "description": "Operation cannot be found. Check request URL.",
    "object": "error"
  },
  "service_name": "child_chain",
  "success": false,
  "version": "1.0.3+e48599b"
}

curl -X GET http://localhost:9656/alarm.get -H "Content-Length: 0" | jq .

# GET should work as normal

{
  "data": [
    {
      "main_supervisor_halted": {
        "node": "child_chain@127.0.0.1",
        "reporter": "Elixir.OMG.ChildChain.Monitor"
      }
    }
  ],
  "service_name": "child_chain",
  "success": true,
  "version": "1.0.3+e48599b"
}

[unnawut]

Lgtm to just early reject headers we don't intend to support. Although can you double check that this works client apps e.g. blockexplorer and webwallet? I think CORS require OPTIONS requests.

If we require OPTIONS also check that MethodParamFilter plug can handle it.

[mederic-p]

Looking good, maybe just rename the plug so it's consistent with MethodParamFilter, you could name it MethodFilter.

[unnawut]

Changed my mind as @mederic-p mentioned separately that our routes should already take care of the unsupported methods. So we only need to update the existing MethodParamFilter plug to handle unknown methods.

[unnawut]

amazingly amazing