Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing clause on witness validation check #1656

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Add missing clause on witness validation check #1656

merged 4 commits into from
Jul 22, 2020

Conversation

mederic-p
Copy link
Contributor

@mederic-p mederic-p commented Jul 21, 2020 •
edited
Loading

Closes #1158

Fixes a crash when given an array of array of RLP encoded signatures.

@mederic-p mederic-p self-assigned this Jul 21, 2020
@mederic-p mederic-p added the bug Something isn't working label Jul 21, 2020
@mederic-p mederic-p merged commit ae9882a into master Jul 22, 2020
@mederic-p mederic-p deleted the mederic-p/signature-validation branch July 22, 2020 09:22
@unnawut
Copy link
Contributor

unnawut commented Jul 22, 2020

much wow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripzery ripzery ripzery approved these changes

@T-Dnzt T-Dnzt T-Dnzt approved these changes

@pnowosie pnowosie Awaiting requested review from pnowosie

Assignees

@mederic-p mederic-p

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List of lists of signatures borks the endpoint process for transaction.submit
4 participants
@mederic-p @unnawut @T-Dnzt @ripzery