Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrrectly serialize PIDs in alarms.get #1678

Merged
merged 4 commits into from
Aug 7, 2020

Conversation

ayrat555
Copy link
Contributor

Fixes #1619

Overview

Add Jason.Encoder for PID.

@InoMurko
Copy link
Contributor

InoMurko commented Aug 3, 2020

I would actually go down the route of setting the treshold to 1.0 so that the memory alarm never gets triggered (cc @unnawut). We report memory to Datadog and we can set our monitoring there. Wdyt @unnawut ?

@unnawut
Copy link
Contributor

unnawut commented Aug 5, 2020

Hmm true I think this alarm is not needed for external consumption

@InoMurko
Copy link
Contributor

InoMurko commented Aug 5, 2020

cool. @ayrat555 if you could adapt this based on the comments it would be wonderful/better. thanks!

@ayrat555
Copy link
Contributor Author

ayrat555 commented Aug 6, 2020

@InoMurko @unnawut done

@unnawut
Copy link
Contributor

unnawut commented Aug 7, 2020

Amazing thanks 😂 Can you also set this alarm up in our monitoring tool as we merge this so we don't lose the alarm?

@ayrat555
Copy link
Contributor Author

ayrat555 commented Aug 7, 2020

@unnawut what do you mean? I think this change will remove the alarm

@unnawut
Copy link
Contributor

unnawut commented Aug 7, 2020

@unnawut what do you mean? I think this change will remove the alarm

Ah Ino said it better than me prior 😂 "We report memory to Datadog and we can set our monitoring there."

@ayrat555
Copy link
Contributor Author

ayrat555 commented Aug 7, 2020

@InoMurko @unnawut I don't think Datadog has the ability to monitor erlang processes

@unnawut
Copy link
Contributor

unnawut commented Aug 7, 2020

@InoMurko @unnawut I don't think Datadog has the ability to monitor erlang processes

Maybe https://github.com/ferd/vmstats that we have now? It taps into what erlang's memory module provides and already reporting to Datadog. There's vmstats.memory.proc_used and etc. but will need some digging into how to calculate for the alarm.

(I think this doesn't block merging of this PR though)

@ayrat555 ayrat555 merged commit 8ddf382 into master Aug 7, 2020
@ayrat555 ayrat555 deleted the ayrat555/correctly-serialize-pids-in-alarms branch August 7, 2020 06:30
@unnawut unnawut added the bug Something isn't working label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants