fix: set :last_ife_exit_deleted_eth_height on deplyment if it's not set yet #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgebal
force-pushed
the
pgebal/fix_event_listeners_update_key_not_initialized
branch
3 times, most recently
from
8233387
to
617a1f3
Compare
pgebal
force-pushed
the
pgebal/fix_event_listeners_update_key_not_initialized
branch
from
617a1f3
to
1e59cbd
Compare
pgebal
force-pushed
the
pgebal/fix_event_listeners_update_key_not_initialized
branch
2 times, most recently
from
3d3dec7
to
b39108b
Compare
pgebal
force-pushed
the
pgebal/fix_event_listeners_update_key_not_initialized
branch
from
b39108b
to
e4450ac
Compare
pgebal
commented
Sep 9, 2020
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| defmodule OMG.DB.ReleaseTasks.InitKeysWithValues do |
There was a problem hiding this comment.
@InoMurko what do you think about this solution?
It uses a release task to set a value if it's not already set.
I am not sure we should use a config provider here as this does not change config at all.
There was a problem hiding this comment.
Why not take the same approach as OMG.WatcherInfo.ReleaseTasks.InitPostgresqlDB? Why use https://github.com/omgnetwork/elixir-omg/pull/1720/files#diff-3cc6d83c8ce1f76e93166823f0298352R19 a config provider?
There was a problem hiding this comment.
Thanks, that's exactly what I needed.
InoMurko
reviewed
Sep 9, 2020
apps/omg_db/test/omg_db/release_tasks/init_keys_with_values_test.exs
Outdated
Show resolved
Hide resolved
pgebal
force-pushed
the
pgebal/fix_event_listeners_update_key_not_initialized
branch
from
19ab623
to
c5be9f1
Compare
pgebal
force-pushed
the
pgebal/fix_event_listeners_update_key_not_initialized
branch
from
c5be9f1
to
918e0f3
Compare
pgebal
force-pushed
the
pgebal/fix_event_listeners_update_key_not_initialized
branch
from
5e23fd4
to
42bf5de
Compare
pgebal
added
bug
pgebal
force-pushed
the
pgebal/fix_event_listeners_update_key_not_initialized
branch
from
334c391
to
ea8bf5f
Compare
pnowosie
approved these changes
Sep 15, 2020
apps/omg_watcher/lib/omg_watcher/exit_processor/in_flight_exit_info.ex
Outdated
Show resolved
Hide resolved
InoMurko
approved these changes
Sep 15, 2020
…s_update_key_not_initialized
pgebal
force-pushed
the
pgebal/fix_event_listeners_update_key_not_initialized
branch
from
6fb4d73
to
f40b642
Compare
pgebal
deleted the
pgebal/fix_event_listeners_update_key_not_initialized
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back #1714 and adds a release task to update rocksdb for deployments that do not start from a clean state.