Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use golang 1.11 with modules #109

Merged
merged 9 commits into from
Nov 9, 2018
Merged

Use golang 1.11 with modules #109

merged 9 commits into from
Nov 9, 2018

Conversation

rdsubhas
Copy link
Member

@rdsubhas rdsubhas commented Aug 28, 2018 •
edited
Loading

  • Upgrade myke to use golang modules
  • Remove godeps and binary initialization scripts
  • Remove GOPATH
  • Use go-resources instead of go-bindata to embed static assets
  • Update travis CI config
  • Update appveyor CI config spin off into a separate PR since appveyor has not updated golang stack version yet
  • Check binary size and target compatibility - Note: size: 6.2m => 7.6m on macos, refers cmd/compile: significant binary size increase in go1.11 golang/go#27266. Known issue, hence ignoring
  • Check code coverage metrics
  • Check docker development commands and update README
  • Update license generation script to make sure all dependency license from outside GOPATH are now included
  • Remove unneeded indirect dependencies such as overalls, etc. using tools.go as described in cmd/go: clarify best practice for tool dependencies golang/go#25922

Refers #110

@rdsubhas rdsubhas changed the title Golang modules Use golang modules Aug 28, 2018
@rdsubhas rdsubhas changed the title Use golang modules Use golang 1.10 with modules Aug 28, 2018
@rdsubhas rdsubhas changed the title Use golang 1.10 with modules Use golang 1.11 with modules Nov 8, 2018
@rdsubhas rdsubhas force-pushed the golang-11 branch 2 times, most recently from 520ae04 to fb497d7 Compare November 8, 2018 02:28
@rdsubhas rdsubhas force-pushed the golang-11 branch 2 times, most recently from add0b5c to 16148fe Compare November 8, 2018 02:38
@rdsubhas rdsubhas merged commit 7979841 into omio-labs:master Nov 9, 2018
@rdsubhas rdsubhas deleted the golang-11 branch November 9, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnaangr adnaangr adnaangr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdsubhas @adnaangr