update launch.json for VSCode #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bug mode with CodeLLDB or GDB
Python script has trouble parsing arguments otherwise
Allows running debugging sessions when building with Ninja.
|
@riebl - I will test the implementation and add my thoughts before the final merge. |
|
@riebl - sorry for the late response, I was fully concentrating on my simulation. I finally tested all the changes and they work perfectly - also, creating a CMake target is a brilliant solution. I think we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up task of #7, I have rebased the feature branch and amended the update mechanics. I think this feature is now ready to hit our master branch. I am able to debug with both, GDB and CodeLLDB, on my Linux machine.
You have to explicitly enable the VSCode integration by setting the global
VSCODE_ADDONproperty toON. Thevscode_addon_optioncommand is an easy way for CMake projects to control this property via a cache variable. It is thus easy to disable this feature if someone does not want our code to modify his launch.json.@HpLightcorner Could you please check if it is (still) working on Windows?