fix(octane/evmengine): handle engine errors #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
requested review from
sideninja,
chmllr,
kc1116 and
kevinhalliday
as code owners
sideninja
reviewed
Nov 13, 2024
| @@ -32,6 +38,11 @@ func makeProcessProposalRouter(app *App) *baseapp.MsgServiceRouter { | |||
| // It also updates some external state. | |||
| func makeProcessProposalHandler(router *baseapp.MsgServiceRouter, txConfig client.TxConfig) sdk.ProcessProposalHandler { | |||
| return func(ctx sdk.Context, req *abci.RequestProcessProposal) (*abci.ResponseProcessProposal, error) { | |||
| // Only allow 10s to process a proposal. Reject proposal otherwise. | |||
sideninja
reviewed
Nov 13, 2024
|
|
||
| return resp, nil | ||
| return engine.PayloadStatusV1{}, errors.New("nil error and unknown status", "status", resp.Status) |
sideninja
approved these changes
Nov 13, 2024
chmllr
approved these changes
Nov 13, 2024
| @@ -129,30 +108,33 @@ func (c engineClient) ForkchoiceUpdatedV3(ctx context.Context, update engine.For | |||
| const endpoint = "forkchoice_updated_v3" | |||
| defer latency(c.chain, endpoint)() | |||
|
|
|||
| // isStatusOk returns true if the response status is valid. | |||
| isStatusOk := func(resp engine.ForkChoiceResponse) bool { | |||
There was a problem hiding this comment.
I'm curious about this code style: why do you prefer wrapping a map with a closure over simply using a map given it's used once in the function?
There was a problem hiding this comment.
functions are easy to read and document. Also slightly more concise
if isStatusOk(resp) {
vs
if okStatuses[resp.PayloadStatus.Status] {
0xHansLee
added a commit
to piplabs/story
that referenced
this pull request
Nov 28, 2024
This PR is the commit from Omni to handle errors of engineAPI (omni-network/omni#2469). issue: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve EngineAPI error handling:
status:INVALIDAND errors, so swallow errors if known status is returned.issue: #2461