Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS must be forced for RPC connections #79

Closed
akolotov opened this issue May 12, 2018 · 2 comments
Closed

HTTPS must be forced for RPC connections #79

akolotov opened this issue May 12, 2018 · 2 comments
Assignees

Comments

@akolotov
Copy link
Contributor

As per recommendation from a team provided security audit for POA bridge it is needed to force https connection for RPC communications.

In other words RPC connection must not succeed if HTTP is used and the bridge instance must stop.

For testing purposes a new parameter like force_https could be introduced in the configuration file. It's value should be yes by default. If it is necessary to use HTTP connection instead of HTTPS the parameter needs to be set to no.

@yrashk
Copy link
Contributor

yrashk commented May 14, 2018

I would suggest that we only enable http compile-time so that there is no easy "escape hatch" for not enforcing https.

@akolotov
Copy link
Contributor Author

I am using parity nodes configured as private networks for bridge testing, so, it is not only for compile-time.

yrashk added a commit to yrashk/parity-bridge that referenced this issue May 24, 2018
Solution: by default, disallow use of non-TLS RPC endpoints

For testing, there's an escape hatch of a command line
argument `--allow-insecure-rpc-endpoints` (purposefully
long) that will reduce the severity of using a non-TLS
RPC endpoint to a warning in a log file.

It was not made to be a configuration file option to reduce
the risk of this option slipping into a production configuration
file by mistake.

Closes omni#79
@ghost ghost assigned yrashk May 24, 2018
@ghost ghost added the in progress label May 24, 2018
yrashk added a commit to yrashk/parity-bridge that referenced this issue May 28, 2018
Solution: by default, disallow use of non-TLS RPC endpoints

For testing, there's an escape hatch of a command line
argument `--allow-insecure-rpc-endpoints` (purposefully
long) that will reduce the severity of using a non-TLS
RPC endpoint to a warning in a log file.

It was not made to be a configuration file option to reduce
the risk of this option slipping into a production configuration
file by mistake.

Closes omni#79
yrashk added a commit to yrashk/parity-bridge that referenced this issue May 31, 2018
Solution: by default, disallow use of non-TLS RPC endpoints

For testing, there's an escape hatch of a command line
argument `--allow-insecure-rpc-endpoints` (purposefully
long) that will reduce the severity of using a non-TLS
RPC endpoint to a warning in a log file.

It was not made to be a configuration file option to reduce
the risk of this option slipping into a production configuration
file by mistake.

Closes omni#79
yrashk added a commit to yrashk/parity-bridge that referenced this issue Jun 4, 2018
Solution: by default, disallow use of non-TLS RPC endpoints

For testing, there's an escape hatch of a command line
argument `--allow-insecure-rpc-endpoints` (purposefully
long) that will reduce the severity of using a non-TLS
RPC endpoint to a warning in a log file.

It was not made to be a configuration file option to reduce
the risk of this option slipping into a production configuration
file by mistake.

Closes omni#79
@yrashk yrashk closed this as completed in #86 Jun 4, 2018
@ghost ghost removed the in progress label Jun 4, 2018
noot pushed a commit to noot/poa-bridge that referenced this issue Jul 18, 2018
Solution: by default, disallow use of non-TLS RPC endpoints

For testing, there's an escape hatch of a command line
argument `--allow-insecure-rpc-endpoints` (purposefully
long) that will reduce the severity of using a non-TLS
RPC endpoint to a warning in a log file.

It was not made to be a configuration file option to reduce
the risk of this option slipping into a production configuration
file by mistake.

Closes omni#79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants