Problem: no functionality exists to dynamically fetch gas-prices #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, gas-prices are set upon bridge startup via the Users's config TOML file; this value remains constant for the life of the Bridge. Solution: create a mechanism that asynchronously queries gas-prices from an "Oracle" service on a timed interval. This mechanism should be a stream of gas-prices that can be polled from the Bridge.
ghost
assigned 
yrashk
approved these changes
May 24, 2018
There was a problem hiding this comment.
Great job! Tiny nitpick (for future): the problem statement defines the problem via solution (no functionality exists..), a better one would be to highlight the actual problem, something like... "Problem: static gas price could at times be too low" (for example)
noot
pushed a commit
to noot/poa-bridge
that referenced
this pull request
Jul 18, 2018
omni#85 (ERC20 for ForeignBridge) and more
noot
pushed a commit
to noot/poa-bridge
that referenced
this pull request
Jul 18, 2018
Problem: no functionality exists to dynamically fetch gas-prices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: currently, gas-prices are set upon bridge startup via the
Users's config TOML file; this value remains constant for the
life of the Bridge.
Solution: create a mechanism that asynchronously queries
gas-prices from an "Oracle" service on a timed interval. This
mechanism should be a stream of gas-prices that can be polled
from the Bridge.