Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: authorities.accounts config setting is obsolete #94

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Problem: authorities.accounts config setting is obsolete #94

merged 1 commit into from
Jun 4, 2018

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented May 25, 2018

Solution: make it only accessible when deploy feature is on
(for integration tests)

@ghost ghost assigned yrashk May 25, 2018
@ghost ghost added the in progress label May 25, 2018
akolotov
akolotov reviewed May 26, 2018
View reviewed changes
Copy link
Contributor

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update README.md and examples/config.toml.

@yrashk yrashk force-pushed the accounts-deprecation branch from 9b7f878 to 15772a1 Compare May 28, 2018 18:00
@yrashk
Copy link
Contributor Author

yrashk commented May 28, 2018

Done

@yrashk
Problem: authorities.accounts config setting is obsolete
b68f235 
Solution: make it only accessible when `deploy` feature is on
(for integration tests)

Closes omni#73
@yrashk yrashk force-pushed the accounts-deprecation branch from 15772a1 to b68f235 Compare May 28, 2018 18:16
akolotov
akolotov approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. But in order to minimize number of changes in the next version of bridge, the merge needs to be done as soon as the tag for the commit for #93 is published as a new release.

@yrashk yrashk merged commit bbda17d into omni:master Jun 4, 2018
@ghost ghost removed the in progress label Jun 4, 2018
@akolotov akolotov mentioned this pull request Jun 5, 2018
Closed
noot pushed a commit to noot/poa-bridge that referenced this pull request Jul 18, 2018
@debris
Merge pull request omni#94 from paritytech/snd-auto-compile-contracts
94c0aa6 
compile contracts in build.rs and remove compiled from git so they do…
noot pushed a commit to noot/poa-bridge that referenced this pull request Jul 18, 2018
@yrashk
Merge pull request omni#94 from yrashk/accounts-deprecation
78920f3 
Problem: authorities.accounts config setting is obsolete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolotov akolotov akolotov approved these changes

Assignees

@yrashk yrashk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yrashk @akolotov