Handle status of deployment transaction #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 5, 2018 21:20
* Description for the parameters related to the gas price was updated * Ambiguity for unused parameters was eliminated
ghost
assigned 
patitonar
approved these changes
Nov 6, 2018
fvictorio
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the status of deployment transactions was handled as a string presented the hexadecimal value "0x1". It was found that some Ethereum-compliant clients (e.g. RSKj) return the status as "0x01".
In order to allow the deployment script works on such clients, the status values is converted to the decimal form and compared with 1.
This PR is based on changes from #105 and #103, that's why the corresponding changes are reported in the baselines comparison.