Dynamic gas limit for the deployment/configuration transactions #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th a constant GAS_LIMIT
ghost
assigned 
patitonar
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach is to use a constant configured in
.envfile as the gas limit for the deployment/configuration transactions. It leads to situations when the example configuration file needs to be updated every time when we change the contracts significantly. Sometimes we missed this step that's why adopters experiencing the issue with the bridge contracts deployment.The suggested changes introduce call of
eth_estimateGasbefore sending a transaction. The received value is increased by an extra gas depending on the newDEPLOYMENT_GAS_LIMIT_EXTRAparameter.