-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove proxyOwner method from proxy contract #198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We got the following comment during the security audit:
line 10 (
address private _upgradeabilityOwner;
), why do you useprivate
visibility modifier instead ofinternal
? (edited)
Do you think it make sense to make this one-line-change under this PR?
Sure, it is related. Added the change on this commit e73d2aa |
Closes #195