Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proxyOwner method from proxy contract #198

Merged
merged 9 commits into from
Jun 27, 2019
Merged

Conversation

patitonar
Copy link
Contributor

Closes #195

@patitonar patitonar requested a review from akolotov June 19, 2019 18:10
Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got the following comment during the security audit:

line 10 (address private _upgradeabilityOwner;), why do you use private visibility modifier instead of internal? (edited)

Do you think it make sense to make this one-line-change under this PR?

@patitonar
Copy link
Contributor Author

line 10 (address private _upgradeabilityOwner;), why do you use private visibility modifier instead of internal? (edited)
Do you think it make sense to make this one-line-change under this PR?

Sure, it is related. Added the change on this commit e73d2aa

@akolotov akolotov merged commit a1f64ca into develop Jun 27, 2019
@akolotov akolotov deleted the 195-remove-proxyOwner branch June 27, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants