Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove returns from internal initialize method on HomeBridgeErcToErc #221

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Remove returns from internal initialize method on HomeBridgeErcToErc #221

merged 1 commit into from
Jul 2, 2019

Conversation

patitonar
Copy link
Contributor

Closes #215

Reviewed all method that returns values, fixed internal methods _initialize and _rewardableInitialize which shouldn't return any value

@patitonar patitonar requested a review from akolotov July 2, 2019 15:03
@patitonar patitonar self-assigned this Jul 2, 2019
@akolotov akolotov merged commit cc47af2 into develop Jul 2, 2019
@akolotov akolotov deleted the 215-fix-no-return branch July 2, 2019 16:07
@akolotov akolotov mentioned this pull request Jul 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolotov akolotov akolotov approved these changes

Assignees

@patitonar patitonar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patitonar @akolotov