Remove duplicated logic on top of withinExecutionLimit #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212
All the Home contracts had the same implementation for
affirmationWithinLimits
which callswithinExecutionLimit
that is defined onBasicBridge
. It made sense to me to call direclty the methodwithinExecutionLimit
fromBasicHomeBridge
and removeaffirmationWithinLimits
.In order to do that, I had to change the inheritance of
BasicBridge
. NowBasicHomeBridge
extends fromBasicBridge
and Home contracts do it througthBasicHomeBridge
. The changes mentioned are included in this commit e314ee3I found that this same situation was repeated for
messageWithinLimits
onBasicForeignBridge
so I applied similar changes to that method too. These are the changes becb25a