Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated logic on top of withinExecutionLimit #223

Merged
merged 2 commits into from
Jul 3, 2019

Conversation

patitonar
Copy link
Contributor

Closes #212

All the Home contracts had the same implementation for affirmationWithinLimits which calls withinExecutionLimit that is defined on BasicBridge. It made sense to me to call direclty the method withinExecutionLimit from BasicHomeBridge and remove affirmationWithinLimits.

In order to do that, I had to change the inheritance of BasicBridge. Now BasicHomeBridge extends from BasicBridge and Home contracts do it througth BasicHomeBridge. The changes mentioned are included in this commit e314ee3

I found that this same situation was repeated for messageWithinLimits on BasicForeignBridge so I applied similar changes to that method too. These are the changes becb25a

@patitonar patitonar requested a review from akolotov July 3, 2019 13:09
@patitonar patitonar self-assigned this Jul 3, 2019
@akolotov akolotov merged commit 27458bf into develop Jul 3, 2019
@akolotov akolotov deleted the 212-fix-affirmationWithinLimits branch July 3, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants