Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing required block confirmation check in ForeignBridgeNativeToErc #229

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Fix missing required block confirmation check in ForeignBridgeNativeToErc #229

merged 2 commits into from
Jul 12, 2019

Conversation

patitonar
Copy link
Contributor

I found that all home and foreign contracts had checks for _requiredBlockConfirmations parameter on initialize method except for ForeignBridgeNativeToErc. This PR adds the missing check.

@patitonar patitonar requested a review from akolotov July 12, 2019 15:32
@patitonar patitonar self-assigned this Jul 12, 2019
@akolotov akolotov merged commit df1fa67 into develop Jul 12, 2019
@akolotov akolotov deleted the fix-ForeignBridgeNativeToErc-block-confirmations branch July 12, 2019 15:49
@akolotov akolotov mentioned this pull request Jul 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolotov akolotov akolotov approved these changes

Assignees

@patitonar patitonar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patitonar @akolotov