New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent call of onTokenTransfer #412

Merged

akolotov merged 1 commit into develop from fallback-call-consistency

May 4, 2020

Collaborator

akolotov commented May 3, 2020

Below is the list of the reason why these changes were introduced:

It was found that abi.encodeWithSelector is worth to use instead of abi.encodeWithSignature since the contract storage is used in more efficient way.
Other places where onTokenTransfer is being called uses abi.encodeWithSelector.
- ChaiConnector.sol
- GasTokenConnector.sol


          onTokenTransfer call uniformed with rest of the repo

ccbf77b

akolotov requested review from patitonar, k1rill-fedoseev and varasev

May 3, 2020 20:33

varasev approved these changes

View reviewed changes

akolotov merged commit a620e47 into develop

akolotov deleted the fallback-call-consistency branch

May 4, 2020 08:16

akolotov mentioned this pull request

Merge the develop branch to the master branch, preparation to v5.0.0-rc0 #413

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet