Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment scripts when using web3 1.2.9 #442

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Conversation

k1rill-fedoseev
Copy link
Member

Due to a bug in the web3js 1.2.9 library: web3/web3.js#3592, the deployment scripts handled incorrectly BN arrays in the function calls.
Adding an additional .toString() fixes that behaviour.
Updated deployment scripts were tested under the following CI workflow: https://app.circleci.com/pipelines/github/poanetwork/tokenbridge/1882/workflows/eee2a357-33e8-4e0e-ad8e-10cbaf0fddcc

@k1rill-fedoseev k1rill-fedoseev requested a review from akolotov July 1, 2020 11:05
@k1rill-fedoseev k1rill-fedoseev self-assigned this Jul 1, 2020
@akolotov akolotov merged commit f074379 into develop Jul 1, 2020
@akolotov akolotov deleted the fix/deployment-bn branch July 1, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants